On 07/25/2012 03:56 PM, Salar Ali Mumtaz wrote: > Displays the current value of each of the dependencies of a menu item. > Before, you needed to do tedious searching to find out the current values > of the dependences. Now they all are included in the debug_info, making > the task easier Hi, Would you please provide before and after examples? I use xconfig quite a lot and it already shows me, e.g., for CONFIG_DRM: Symbol: DRM [=y] Type : tristate Prompt: Direct Rendering Manager (XFree86 4.1.0 and higher DRI support) Defined at drivers/gpu/drm/Kconfig:7 Depends on: HAS_IOMEM [=y] && (AGP [=y] || AGP [=y]=n) && !EMULATED_CMPXCHG && MMU [=y] Location: -> Device Drivers -> Graphics support Selects: I2C [=y] && I2C_ALGOBIT [=y] && DMA_SHARED_BUFFER [=y] so what and where does this patch add debug info? Thanks. > Signed-off-by: Salar Ali Mumtaz <salaarali@xxxxxxxxx> > --- > scripts/kconfig/qconf.cc | 10 +++++++++- > 1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > index df274fe..abd500f 100644 > --- a/scripts/kconfig/qconf.cc > +++ b/scripts/kconfig/qconf.cc > @@ -1073,8 +1073,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym) > debug += " (choice)"; > debug += "<br>"; > if (sym->rev_dep.expr) { > - debug += "reverse dep: "; > + debug += "reverse dep: ("; > expr_print(sym->rev_dep.expr, expr_print_help, &debug, E_NONE); > + debug += " ) ="; > + debug += print_filter(sym_get_string_value(sym)); > debug += "<br>"; > } > for (struct property *prop = sym->prop; prop; prop = prop->next) { > @@ -1108,7 +1110,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym) > } > if (prop->visible.expr) { > debug += " dep: "; > + debug += " ( "; > expr_print(prop->visible.expr, expr_print_help, &debug, E_NONE); > + debug += " ) ="; > + debug += print_filter(sym_get_string_value(sym)); > debug += "<br>"; > } > } > @@ -1157,6 +1162,9 @@ void ConfigInfoView::expr_print_help(void *data, struct symbol *sym, const char > *text += QString().sprintf("<a href=\"s%p\">", sym); > *text += str2; > *text += "</a>"; > + *text += "<b> "; > + *text += print_filter(sym_get_string_value(sym)); > + *text += "</b>"; > } else > *text += str2; > } -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html