On Tuesday 03 July 2012, Mark Brown wrote:
> On Tue, Jul 03, 2012 at 12:00:59PM +1000, Stephen Rothwell wrote:
> > On Mon, 2 Jul 2012 19:04:10 +0100 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> > > +#define __clk_get(clk) ({ 1; })
> > > +#define __clk_put(clk) do { } while (0)
>
> > So why not:
>
> > struct clk;
>
> > static inline int __clk_get(struct clk *clk) { return 1; }
> > static inline void __clk_put(struct clk *clk) ( )
>
> No idea, I'm just taking the existing default header and making it more
> generally available.
I prefer Stephen's version because that maintains the type checking.
However, that is not a controversial point at all IMHO. The question
that we need to decide on is whether we want automatic "generic-y"
statements in Kbuild.asm.
I'm not opposed to the idea, but I can imagine some arch maintainers
fine it confusing. When you first posted the patch, I spent some
time trying to get the wildcard logic moved to scripts/Makefile.asm-generic
and scripts/Makefile.headersinst but couldn't figure it out in the end.
I would definitely prefer being able to just write
generic-y += clkdev.h
in include/asm-generic/Kbuild.asm, rather than
ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/clkdev.h),)
generic-y += clkdev.h
endif
Maybe Michal Marek or someone on the kbuild mailing list can help
out with a solution for that.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
