Re: [PATCH 1/3] scripts/config: be case-sensitive on config option symbols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andi, All,

On Thursday 07 June 2012 04:54:17 Andi Kleen wrote:
> > With this patch, if the KCONFIG_CASE environment variable is set to (with
> > no quotes):
> >   - 'upper': force symbols to upper-case
> >   - 'lower': force symbols to lower-case
> 
> That's ugly. How about a emacs style heuristic. When the config symbol
> is mixed case do not change the symbol?

Such a heuristic would still break with some of the symbols used in the Linux
tree:
  ./arch/powerpc/platforms/Kconfig.cputype:config 6xx
  ./arch/powerpc/platforms/Kconfig.cputype:config 8xx
  ./arch/powerpc/platforms/Kconfig.cputype:config 4xx

Not to say about other projects which may use lower-case only symbols.

What about adding an option to keep the case as-is:
    --keep-case|-k      Keep symbol's case (dont' upper-case it)

Ideally, we could also add (I'd make a separate patch for that):
    --upper-case|-U     Upper-case the symbol
    --lower-case|-l     Lower-case the symbol

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux