Re: [PATCH 04/23] x86, realmode: Move reboot_32.S to unified realmode code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/09/2012 07:15 AM, Paolo Bonzini wrote:
> 
> I'm not sure I understand.  The code has
> 
> 	andl	$0x60000000, %edx	; clear ET/PE
> 	jz	2f
> 	...
> 2:
> 	andb	$0x10, %dl		; clear CD/WT, %edx is always 0
> 
> 
> What I've suggested is:
> 
> 	testl	$0x60000000, %edx
> 	jz	2f
> 	...
> 2:
> 	andb	$0x10, %dl		; clear PE only
> 
> 
> What would jump to the BIOS with caches on is:
> 
> 	testl	$0x60000000, %edx
> 	jz	2f
> 	...
> 2:
> 	andl	$0x10, %edx		; Clear CD/WT/PE
> 
> 
> Am I missing something?
> 

Not awake yet, sorry...

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux