Hi, On Sat, Jul 30, 2011 at 12:19 PM, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote: > On Sat, 30 Jul 2011, Arnaud Lacombe wrote: > >> this is breaking ARCH=um. > > Breaking in what way? from arch/um/Makefile: [...] include $(srctree)/$(ARCH_DIR)/Makefile-$(SUBARCH) with the following Makefile-$(SUBARCH) available: % ls arch/um/Makefile-* [...] arch/um/Makefile-i386 arch/um/Makefile-x86_64 > Is it just that ARCH=um is broken for SUBARCH=x86, > and needed to be updated anyway? > well, from my point of view, it do not need to be updated. Your patch corrupt SUBARCH's purpose, that is: # SUBARCH tells the usermode build what the underlying arch is. Changing it will start to be really intrusive... > And still works is you manually set > SUBARCH to one of the legacy values? > no. the toplev Makefile use a direct immediate assignment, not a conditional one. - Arnaud > I'll try to reproduce and take a look later thuis evening. > > -- > dwmw2 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
