Hi, On Sat, Jul 9, 2011 at 10:04 PM, Andrej Gelenberg <andrej.gelenberg@xxxxxxx> wrote: > Hello, > > i found and fixed an NULL-dereference bug in nconf tool. > > How to reproduce: > 1. $ make nconfig > 2. disable "Kernel hacking -> Debug Filesystem" > 3. go to "General setup -> GCOV-based kernel profiling" and hit F2 > it should segfault > > Fix: i have added some checks for "struct menu*" to be NULL before it > get dereferenced > I am not a huge fan of this. The frontend should be careful not to try to request the visibility or the prompt of an invalid menu. Following this point of view, I would rather see assertion added than a test for NULL, and fix the frontend appropriately to catch those case. Said otherwise, there is no reason to apply a fix on the backend for an nconfig-only issue. - Arnaud > Regards, > Andrej Gelenberg > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
