On Thu, May 19, 2011 at 11:54:49PM -0700, Andrew Morton wrote: > On Fri, 20 May 2011 09:48:27 +0300 Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote: > > > On Fri, May 20, 2011 at 08:20:42AM +0200, Geert Uytterhoeven wrote: > > > On Fri, May 20, 2011 at 08:15, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote: > > > > If "long" and "long long" types are identical at runtime, > > > > kstrtol() can be aliased to kstrtoll(). > > > > > > > > Unfortunately, one can't write > > > > > > > > __ __ __ __#if sizeof(long) == sizeof(long long) ... > > > > > > One can write #ifdef CONFIG_64BIT instead. > > > > And alignment will match, on any arch, now and in future? > > I don't think so. > > Don't worry about it. > > z:/usr/src/linux-2.6.39> grep -r "#[ ]*if.*CONFIG_64BIT" . | wc -l > 547 > > So much other stuff will break that kstrtofoo is a drop in the bucket. Meh. The point was that patch is obviously correct and will work in future. CONFIG_64BIT means many things and you guys ask me to overload CONFIG_64BIT one more time. On X32, CONFIG_64BIT trick already doesn't technically work. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
