On Thu, May 12, 2011 at 19:03, Michal Marek <mmarek@xxxxxxx> wrote: > I'm not sure if this is the rigt way to fix it. Kbuild.include should > not care about obj-*. The problem is that arg-check is always empty with > KBUILD_NOCMDDEP and if there are no other dependencies, the target will > not be created, right? IMO we only need to make sure that during the > first make run, arg-check always expands to non-empty, even with > KBUILD_NOCMDDEP. So we can drop the $(obj-y) test and do it like this > (untested), can't we? > > diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include > index c034dd7..be39cd1 100644 > --- a/scripts/Kbuild.include > +++ b/scripts/Kbuild.include > @@ -197,6 +197,8 @@ ifneq ($(KBUILD_NOCMDDEP),1) > # User may override this check using make KBUILD_NOCMDDEP=1 > arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \ > $(filter-out $(cmd_$@), $(cmd_$(1))) ) > +else > +arg-check = $(if $(strip $(cmd_$@)),,1) > endif > > # >'< substitution is for echo to work, This works for me, thanks. Tested-by: Rabin Vincent <rabin@xxxxxx> > while at it, we should also add KBUILD_NOCMDDEP to > Documentation/kbuild/kbuild.txt. I will try to write up something for this. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
