Hi,
On Wed, May 11, 2011 at 5:27 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> On Tue, 10 May 2011, jim.cromie@xxxxxxxxx wrote:
>
>> From: Jim Cromie <jim.cromie@xxxxxxxxx>
>>
>> fix following err by escaping end-of-line $ in regex.
>> perl /home/jimc/projects/lx/linux-2.6/scripts/export_report.pl > /dev/null
>> sed: -e expression #1, char 5: unterminated `s' command
>> sh: .mod.c/: not found
>>
>> without this fix, SECTION 2 of report is empty.
>>
>> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
>> ---
>> scripts/export_report.pl | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
>> index 04dce7c..91fa5a2 100644
>> --- a/scripts/export_report.pl
>> +++ b/scripts/export_report.pl
>> @@ -50,7 +50,7 @@ sub usage {
>>
>> sub collectcfiles {
>> my @file
>> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
>> + = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;
This is bogus. the first \ is still eaten by the shell. All what
sed(1) will see is the '.'.
Btw, that's an awful lot of command to do a simple task. grep(1) and
cat(1) can be done within sed(1), so I guess the patch should looks
like:
- = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
+ = `sed '/\.ko$/!d; s/\.ko$/.mod.c/' .tmp_versions/*.mod`;
[not tested]
- Arnaud
>> chomp @file;
>> return @file;
>> }
>
> Thanks for the fix, Jim.
>
> Adding Michal and linux-kbuild@, this should rather go in through his
> tree.
>
> --
> Jiri Kosina
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
