Hi,
On Thu, May 5, 2011 at 9:32 AM, Michal Marek <mmarek@xxxxxxx> wrote:
> Hi Arnaud,
>
> nice cleanup, I only have a few random comments to this and other patches.
>
> On Wed, May 04, 2011 at 10:03:22PM -0400, Arnaud Lacombe wrote:
>> # Shipped files
>> # ===========================================================================
>>
>> quiet_cmd_shipped = SHIPPED $@
>> cmd_shipped = cat $< > $@
>>
>> -$(obj)/%:: $(src)/%_shipped
>> +$(obj)/%.tab.c: $(src)/%.tab.c_shipped
>> + $(call cmd,shipped)
>> +
>> +$(obj)/lex.%.c: $(src)/lex.%.c_shipped
>> + $(call cmd,shipped)
>> +
>> +$(obj)/%.hash.c: $(src)/%.hash.c_shipped
>> $(call cmd,shipped)
>
> Please don't change this rule, there are other uses of _shipped files in the
> tree than just bison/lex/gperf generated files.
>
I could not make the other implicit target work without changing this one. Ie:
$(src)/%.tab.c_shipped: $(src)/%.y
$(call cmd,bison)
was not working with the _shipped rules left intact, but hardcoding
stem value, eg.:
$(src)/zconf.tab.c_shipped: $(src)/zconf.y
$(call cmd,bison)
was working, at least to link the different implicit target, but
that's breaking other part. I'll try to re-investigate tonight.
- Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
