On Mon, Mar 21, 2011 at 08:47:48AM +0100, Uwe Kleine-König wrote:
> On Sun, Mar 20, 2011 at 05:53:24PM -0700, Linus Torvalds wrote:
> > On Sat, Mar 19, 2011 at 1:58 AM, Michal Marek <mmarek@xxxxxxx> wrote:
> > >
> > > * Section mismatch analysis enabled by default
> > > - there are only a few warnings for defconfig builds,
> > > all{yes,mod}config still has a lot of them. Depending on the general
> > > perception of this change, we might disable it later in the rc phase
> > > again.
> >
> > No.
> >
> > We don't enable stuff like this by default. Not when it actually
> > changes some really fundamental compiler flags, and thus the whole "we
> > can disable it late in -rc again" is a totally broken option, since if
> > we have any compiler issues, we'd want to know it early.
OK, point taken.
> Michal, do you want just remove the default y and squash it into the
> commit?
I'm about to add this to the kbuild branch. Linus, would you pull such
version?
From: Michal Marek <mmarek@xxxxxxx>
Subject: [PATCH] kbuild: Make DEBUG_SECTION_MISMATCH selectable, but not on by default
CONFIG_DEBUG_SECTION_MISMATCH has also runtime effects due to the
-fno-inline-functions-called-once compiler flag, so forcing it on
everyone is not a good idea.
Signed-off-by: Michal Marek <mmarek@xxxxxxx>
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8b6a4f1..5a24805 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -102,7 +102,6 @@ config HEADERS_CHECK
config DEBUG_SECTION_MISMATCH
bool "Enable full Section mismatch analysis"
- default y
help
The section mismatch analysis checks if there are illegal
references from one section to another section.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
