On 13.3.2011 08:19, Sam Ravnborg wrote: > Hi Michal. > > Patch serie looks good. > You can add my ack to all of them if you do a second round. Thanks. > On Sun, Mar 13, 2011 at 07:30:18AM +0100, Michal Marek wrote: >> This series makes genksyms remember the values of enum constants and use them >> during symbol expansion. This makes sure that patches like >> >> | enum e { >> | E1, >> | E2, >> |+ E3, >> | E_MAX >> | }; >> | >> | struct s { >> | int a[E_MAX]; >> | } >> | >> | int f(struct s *s) { ... } >> | EXPORT_SYMBOL(f) >> >> change the checksum of the exported symbol. Previously, it would just use the >> string "E_MAX" in the calculation and the change would go unnoticed. The main >> part is in patches 6/7 and 7/7, the rest are cleanups and preparatory patches. > > This nice explanation would be good to include in the changelog > of 7/8 so "git log" give a better intro to the changes. Good idea, I'll update the patch description. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html