Hi, 2010/12/21 Michal Marek <mmarek@xxxxxxx>: > On 5.12.2010 07:35, Arnaud Lacombe wrote: >> note: I would not mind adding the KCONFIG_VERBOSE logic. >> >> Original idea and implementation by Bastian Blank <waldi@xxxxxxxxxx>, >> Maximilian Attems <max@xxxxxxx> and Ben Hutchings <ben@xxxxxxxxxxxxxxx> >> >> CC: Ben Hutchings <ben@xxxxxxxxxxxxxxx> >> Signed-off-by: Arnaud Lacombe <lacombar@xxxxxxxxx> >> --- >> scripts/kconfig/conf.c | 14 +++++++++++++- >> scripts/kconfig/confdata.c | 4 ++-- >> 2 files changed, 15 insertions(+), 3 deletions(-) >> >> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c >> index 5459a38..1b58129 100644 >> --- a/scripts/kconfig/conf.c >> +++ b/scripts/kconfig/conf.c >> @@ -411,6 +411,17 @@ conf_childs: >> indent -= 2; >> } >> >> + >> +static void >> +listnewconfig_print_symbol(FILE *fp, struct symbol *sym, const char *val, void *arg) >> +{ >> + fprintf(fp, "%s%s (default: %s)\n", CONFIG_, sym->name, val); >> +} > > Ben, do you have an opinion on this format versus the standard .config > produced by your patch? > FWIW, this was just a quick and dirty implementation using the previous patch. I do not really care about the printed format, nor how it interacts with the environment. So I'm open to anything :) - Arnaud > Michal >> + >> +static struct conf_printer listnewconfig_printers = { >> + .print_symbol = listnewconfig_print_symbol, >> +}; >> + >> static void check_conf(struct menu *menu) >> { >> struct symbol *sym; >> @@ -425,7 +436,8 @@ static void check_conf(struct menu *menu) >> (sym_is_choice(sym) && sym_get_tristate_value(sym) == yes)) { >> if (input_mode == listnewconfig) { >> if (sym->name && !sym_is_choice_value(sym)) { >> - printf("%s%s\n", CONFIG_, sym->name); >> + conf_write_symbol(stdout, sym, >> + &listnewconfig_printers, NULL); >> } >> } else if (input_mode != oldnoconfig) { >> if (!conf_cnt++) >> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c >> index 31d06da..6f2f3a4 100644 >> --- a/scripts/kconfig/confdata.c >> +++ b/scripts/kconfig/confdata.c >> @@ -548,8 +548,8 @@ static struct conf_printer tristate_printer_cb = >> * >> */ >> >> -static void conf_write_symbol(FILE *fp, struct symbol *sym, >> - struct conf_printer *printer, void *printer_arg) >> +void conf_write_symbol(FILE *fp, struct symbol *sym, >> + struct conf_printer *printer, void *printer_arg) >> { >> const char *str; >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html