On Wed, 2010-09-22 at 18:32 +0100, Arnaud Lacombe wrote:
> On Wed, Sep 22, 2010 at 7:08 AM, Catalin Marinas
> <catalin.marinas@xxxxxxx> wrote:
> > In your patch, could you also remove the additional expr_copy() when
> > transforming dir_dep (my first patch which wasn't solving the problem
> > but an extra copy is superfluous).
>
> isn't there more superfluous stuff ? The following:
[...]
> @@ -292,8 +291,7 @@ void menu_finalize(struct menu *parent)
> menu_finalize(menu);
> } else if (sym) {
> /* ignore inherited dependencies for dir_dep */
> - sym->dir_dep.expr = expr_transform(expr_copy(parent->dir_dep));
> - sym->dir_dep.expr = expr_eliminate_dups(sym->dir_dep.expr);
> + sym->dir_dep = parent->dep;
With this change I get:
/work/Linux/linux-2.6-arm/scripts/kconfig/menu.c: In function âmenu_finalizeâ:
/work/Linux/linux-2.6-arm/scripts/kconfig/menu.c:301: error: incompatible types
when assigning to type âstruct expr_valueâ from type âstruct expr *â
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
