Sam Ravnborg <sam@xxxxxxxxxxxx> writes:
> On Sat, Sep 18, 2010 at 07:25:32PM -0700, Junio C Hamano wrote:
>> In 60f33b8 (kconfig: get rid of stray a.o, support ncursesw, 2006-01-15),
>> support to link menuconfig with ncursesw library was added. To compute
>> the linker command option -l, we check "libncursesw.{so,a,dylib}" to allow
>> ncursesw to be used as a replacement ncurses. However, when checking what
>> header file to include, we do not check /usr/include/ncursesw directory.
>>
>> Add /usr/include/ncursesw to the list of directories that are checked.
>> With this patch, on my Debian Lenny box with libncursesw5-dev package but
>> not libncurses5-dev package, I can say "make menuconfig".
>>
>> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
>
> Except for the missing patch subject then it looks OK.
> Suggested subject:
> kconfig: fix menuconfig on debian lenny
Sorry, the missing subject really was sloppy of me, and thanks.
> Add as this is a fix we should Cc: <stable@xxxxxxxxx>?
I don't think the fix deserves to be in stable. It does not look like
60f33b8 made it possible to use ncursesw on a box like mine so the patch
is not evan an regression-fix.
> Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Thanks; is it my responsibility to follow-up the thread with identical
patch with updated Subject and with your Ack, hoping somebody in kbuild
team would pick it up?
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
