On Fri, Sep 10, 2010 at 11:32 AM, Stephen Boyd <bebarino@xxxxxxxxx> wrote: > When getting the help for a choice menu with a help section (for example > the "Choose SLAB allocator" menu) nconfig pops up a window with nothing > inside it. This is due to show_help() passing an empty string to > show_scroll_win()'s 3rd argument. The option really does have help > though, but it isn't a config symbol, so just add the help text for > the option, and don't try to add anything else like the config option > name. Acked-by: Nir Tzachar <nir.tzachar@xxxxxxxxx> > Signed-off-by: Stephen Boyd <bebarino@xxxxxxxxx> > Cc: Nir Tzachar <nir.tzachar@xxxxxxxxx> > --- > scripts/kconfig/nconf.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c > index 2ba71bc..19d3401 100644 > --- a/scripts/kconfig/nconf.c > +++ b/scripts/kconfig/nconf.c > @@ -1252,6 +1252,8 @@ static void show_help(struct menu *menu) > str_append(&help, _(menu_get_help(menu))); > str_append(&help, "\n"); > get_symbol_str(&help, menu->sym); > + } else { > + str_append(&help, _(menu_get_help(menu))); > } > } else { > str_append(&help, nohelp_text); > -- > 1.7.2.3.313.gcd15 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html