On Wed, Sep 01, 2010 at 11:21:30AM -0400, Kyle McMartin wrote: > From: Kyle McMartin <kyle@xxxxxxxxxx> > > Commit 861b4ea4 broke oldnoconfig when removed the oldnoconfig checks on > if (input_mode == nonint_oldconfig || > input_mode == oldnoconfig) { > if (input_mode == nonint_oldconfig && > sym->name && > !sym_is_choice_value(sym)) { > to avoid oldnoconfig chugging through the else stanza. > > Fix that to restore expected behaviour (which I've confirmed in the > Fedora kernel build that the configs end up looking the same.) I played aroud with this. I looks like the only difference I got was that before your patch oldnoconfig produced a lot of output to stdout. With your patch is was silent. The resulting config was the same. We obviously want the silent variant. Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html