Hi, (please Cc me on replies as I'm not subscribed to linux-kbuild@) while building Debian packages of my own kernel version I stumbled upon a build problem with a Debian mechanism, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591793 Why I'm reporting this issue: in scripts/setlocalversion there's the following comment (hint: "apped" should be "append"): # apped a plus sign if the repository is not in a clean tagged # state and LOCALVERSION= is not specified Ok, so testing with a clean and untagged state and empty LOCALVERSION using master of current git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git: % cd linux-2.6 % make defconfig % make prepare % git status # On branch master nothing to commit (working directory clean) % scripts/setlocalversion + Alright. But: % git branch * master % git show master | head -1 commit d1b113bb028999e82a8528e1484be8c23fb5a7d9 % git tag master-test d1b113bb028999e82a8528e1484be8c23fb5a7d9 % scripts/setlocalversion + Huh? Ok, scripts/setlocalversion uses 'git describe --exact-match': % git describe --exact-match fatal: no tag exactly matches 'd1b113bb028999e82a8528e1484be8c23fb5a7d9' % git branch --contains d1b113bb028999e82a8528e1484be8c23fb5a7d9 * master For my understanding this *is* a tagged and clean state of the repository. But I'm not sure whether that's a bug in 'git describe --exact-match' or if scripts/setlocalversion of recent kernel versions should be adjusted (either the check for the untagged state or clarify/improve the comment about it). regards, -mika-
Attachment:
signature.asc
Description: Digital signature
