Re: [PATCH] kbuild: implement the `mainmenu' directive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Aug 17, 2010 at 4:26 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Tue, Aug 17, 2010 at 01:24:23PM +0200, Michal Marek wrote:
>> On 17.8.2010 07:42, Arnaud Lacombe wrote:
>> > +   if (isspace(*prompt)) {
>> > +           fprintf(stderr, "%s:%d:warning: leading whitespace ignored\n",
>> > +               current_file->name, zconf_lineno());
>> > +           while (isspace(*prompt))
>> > +                   prompt++;
>> > +   }
>>
>> The lexer already eats whitespace I think, so this might not be necessary.
>
> menu_add_prop() does something similar so I think not.
> But I did not check.
>
The leading whitespace removal have been added explicitly by Roman Zippel:

commit f001f7f89689d3226678ab3986f3a486f54aa069
Author: Roman Zippel <zippel@xxxxxxxxxxxxxx>
Date:   Thu Jun 8 22:12:48 2006 -0700
    kconfig: warn about leading whitespace for menu prompts

    Kconfig does its own indentation of menu prompts, so warn about and ignore
    leading whitespace.  Remove also a few unnecessary newlines after other
    warning prints.

    Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
    Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

Not sure if that would still apply for the mainmenu.

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux