Hi, On Mon, Aug 16, 2010 at 8:36 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Hi Arnaud. > > I am very much in favour of getting kconfig less tied into the kernel. > We discussed this topic briefly af the buildrrot list the other day, > and I am started to look at it too. > > What you have done below looks like similar attempts > I have seen in the past - and I did not like them then > and do not like it now. > I have outlined below there three steps needed as I see it. > And I would be very glad for help on two of these. > > 1) "Kernel" appear in diverse feedback texts > - Re-phrase this to refer to the configuration. > You know that you change the configuration > of kernel/buildroot/ptxdist/whatever and > there is no value of repeating this info in > the feedback texts. > - Re-phrasing have the benefit that once the > translators pick up the new version the > translated text is valied for all users. > This would not be the case if you replace > the project name. > sounds good. This would also eliminate the line length problem for hardcoded paragraph. > 2) References to kernel + version in title in frontends > - Use the (today unused) mainmenu entry to pick up the > title. > Consider following example: > > mainmenu "Linux kernel configuration v$KERNELVERSION" > > config KERNELVERSION > string > option env=KERNELVERSION > > With the above exampe we no longer hardcode > the title and we use already existing features > to get the version from the environment. > The expansion of "$KERNELVERSION" to the value > of the symbol is something I only see supported > by "mainmenu". > - This should also address the cases where we > referer to the project name/version in the > .config file (see confdata.c). > seems a good way to go. > 3) Do not hardcode "CONFIG_" > - I suggest to introduce a single define named "CONFIG_". > All the places that hardcode the length should be > replaced by strlen(CONFIG_). > - The define should be conditional like this: > #if !defined(CONFIG_) > #define CONFIG_ "CONFIG_" > #endif > In this way other users can just use -DCONFIG_=BR2_ as they prefer. > agreed. the only thing I am not really fond of is that "strlen(...)" is computed at runtime, whereas "sizeof(...)-1" is a build time constant, but this might not be that worth. > Your patch #2 needs only small adjustments to implement 3). > Please adjust and resend. > will do. > Your patch #1 identifies all places where a re-phrase is needed. > It would be good if you could give that a try. > will do. > I am working on 2) as time permits. It seems doable. > I have something ready within a few days/weeks. > ok. > Please always cc: Michal Marek on patches touching kconfig. > He is the (unofficial) maintainer of kconfig. > We have not heard from Roman Zippel for > one year :-( > shouldn't MAINTAINERS be updated to reflect this ? Thanks, - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
