On Fri, Aug 6, 2010 at 4:54 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: >> >> >> >> Searching: pressing '/' triggers search mode. nconfig performs a >> >> regular string compare, case insensitive, starting at >> > >> > I would say: simple string compare >> > "regular" has no meaning (at least for me) there. > > pressing '/' triggers interactive search mode. nconfig search for the > string in the menu prompts (no regex support). > > [Just a suggestion for a bt different wording] > >> > Maybe I should just stick to config symbol searches. I don't think it's all >> > that likely that people will know how each menu line text begins. >> > >> > >> >> We can replace strcasecmp with strcasestr. I agree it would be more useful. > > This is better. > >> >> > As for the search UI, I'd rather that it be presented like the symbol search, >> > in a box, instead of just a single line at the top of the screen. >> >> But then it is not interactive. I was aiming for something similar to >> vim's search, where the search is matched as you type and the only >> free terminal real-estate to display the match string was at the top >> of the screen. I think such a minimal design is better than a >> cumbersome text box which displays the search results afterwards (as >> is symbol search), as the search is only intended for the currently >> displayed menu and the user would usually just want to save the extra >> typing of navigating to a specific menu item. > > It was introduced to replace the "hotkey" support, and as such is useful. > If we want to search for content of all prompts then we should extend > the symbols search to do so. > Maybe we should just let it search for both symbols _and_ propmts. There is a different alternative which slipped my mind, which can be useful for Randy's use case: just use the single menu mode of nconfig and then the search feature will give you the behavior you desire (i.e., jumping to the globally matching prompt). > If one search for HOTPLUG_CPU there is no hits in any propmts anyway. > And if one search for "Pentium" there is no config symbol hits. If such a search cannot return the menu context of the matching symbol, there is no way for nconfig to jump to the matching menu. But a different approach may be to add the symbol search to nconfig's search, such that instead of just matching the prompt, nconfig will also match the symbol. Cheers, Nir. > Sam > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
