On Sun, Aug 1, 2010 at 12:28 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > On Sun, Aug 01, 2010 at 10:20:33AM +0300, nir.tzachar@xxxxxxxxx wrote: >> From: Nir Tzachar <nir.tzachar@xxxxxxxxx> >> >> Remove the old hotkeys feature, and replace by a regular string search. >> >From nconfig help: >> >> Pressing '/' triggers search mode. nconfig does regular string match, case >> insensitive, starting at the begining of each menu line. >> Pressing Enter highlights the next match, Backspace removes one character from >> the match string. Pressing either '/' again or ESC exits search mode. >> >> Rebind the '/' key (which allowed to search for symbols) to F8 >> >> Signed-off-by: Nir Tzachar <nir.tzachar@xxxxxxxxx> > > Got following warning when I build: > scripts/kconfig/nconf.c: In function ât_mext_matchâscripts/kconfig/nconf.c:512: warning: implicit declaration of function âblankâ > > The searching works great! And good to see the capitilazation gone. Perhaps now we can make nconfig the default?? ;) > But it is ackward that I have to press ESC to leave searcing. > > I can navigate up/down, but entering a menu should terminate search. > Also pressing enter (to select a symbol) should terminate search. > > I also tried to do first search using "/", then search for a symbol using F8. > Again search was not terminated when I came back. > > There is likely much more cases... Sure, but we need to come up with a good description of the behavior we desire. As we did not discuss it, I just went ahead and implemented a POC. As to your input, the main problem with terminating a search is how to still allow iteration between possible matches. We can let Return terminate the search and use a different key (say, 'p') to navigate to the next match. However, I dislike this idea, but if no one can come up with something prettier, I'll implement it. > Sam Cheers. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
