Steven Rostedt wrote at 15:07:29
> On Thu, 2010-05-27 at 13:42 +0200, Toralf Förster wrote:
> > IMHO there's no need for a copy-by-value
>
> Hi Toralf,
>
> I'm sorry but "Your Humble Opinion" is not rational to make changes.
>
> A change to the code must have a reason other than opinion. You must be
> able to show that there is actual benefit for a change, or at least
> explain it.
>
> Every time a change is made, there is potential for a new bug to be
> introduced (especially in Perl). So, unless there's actual need for a
> change, don't make one.
>
> This is not performance critical code. If you are fixing a bug, or
> adding a feature, then sure. But I really don't want changes that do
> nothing but skin the cat a different way.
>
> Thanks,
>
> -- Steve
Understood and accepted.
What's about the following 2 snippets (a trivial typo and an attempt to
prevent a possible trap) ? :
diff --git a/scripts/kconfig/streamline_config.pl
b/scripts/kconfig/streamline_config.pl
index afbd54a..3f54911 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -242,7 +242,7 @@ foreach my $makefile (@makefiles) {
foreach my $obj (split /\s+/,$objs) {
$obj =~ s/-/_/g;
if ($obj =~ /(.*)\.o$/) {
- # Objects may bes enabled by more than one config.
+ # Objects may be enabled by more than one config.
# Store configs in an array.
my @arr;
diff --git a/scripts/kconfig/streamline_config.pl
b/scripts/kconfig/streamline_config.pl
index afbd54a..9726946 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -307,7 +307,7 @@ close (LIN);
my %configs;
foreach my $module (keys(%modules)) {
if (defined($objects{$module})) {
- @arr = @{$objects{$module}};
+ my @arr = @{$objects{$module}};
foreach my $conf (@arr) {
$configs{$conf} = $module;
}
--
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
