On Wed, May 05, 2010 at 10:41:44AM -0700, Greg Thelen wrote: > Michal, > > I'm looking Makefile in the -mm branch (dated 2010-04-28-16-53) and > seeing what looks like a bug in the checking of scm-identifier. The > "ifneq ($scm-identifier)" seems to always execute "ifeq > ($(LOCALVERSION,)) ...". This patch fixes the checking of > scm-identifier. Good catch, thanks! Michal > Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx> > Acked-by: David Rientjes <rientjes@xxxxxxxxxx> > > --- > Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index 6e8cc20..beeb757 100644 > --- a/Makefile > +++ b/Makefile > @@ -943,7 +943,7 @@ endif > ifdef CONFIG_LOCALVERSION_AUTO > localver-extra = $(scm-identifier) > else > - ifneq ($scm-identifier,) > + ifneq ($(scm-identifier),) > ifeq ($(LOCALVERSION),) > localver-extra = + > endif > -- > 1.7.0.1 > > -- > Greg -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
