On Tue, Apr 27, 2010 at 4:56 AM, Jason Wessel <jason.wessel@xxxxxxxxxxxxx> wrote: > When using remake, which is based on gnumake, if you invoke > an example build as shown below, the build will become silent > due to the top level make file incorrectly guessing that > the end user wants a silent build because an argument that > contained an "s" was used. > > remake --no-extended-errors > > Fix up the top level Makefile to use filter with a list of > options that mean silent with the various revisions of gnumake, > instead of findstring. > > Signed-off-by: Jason Wessel <jason.wessel@xxxxxxxxxxxxx> > CC: Michal Marek <mmarek@xxxxxxx> > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > CC: linux-kbuild@xxxxxxxxxxxxxxx Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> Thanks. > --- > Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index fa1db90..91ae299 100644 > --- a/Makefile > +++ b/Makefile > @@ -294,7 +294,7 @@ endif > # If the user is running make -s (silent mode), suppress echoing of > # commands > > -ifneq ($(findstring s,$(MAKEFLAGS)),) > +ifneq ($(filter s% -s% --silent --quiet,$(MAKEFLAGS)),) > quiet=silent_ > endif > > -- > 1.6.3.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
