From: Stephen Hemminger <shemminger@xxxxxxxxxx>
Turn on strict checking.
Use local file handles and 3 argument open.
Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
Acked-by: WANG Cong <amwang@xxxxxxxxxx>
Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
Cc: Michal Marek <mmarek@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/markup_oops.pl | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff -puN scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings scripts/markup_oops.pl
--- a/scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings
+++ a/scripts/markup_oops.pl
@@ -1,5 +1,7 @@
#!/usr/bin/perl
+use strict;
+
use File::Basename;
use Math::BigInt;
use Getopt::Long;
@@ -126,7 +128,7 @@ sub process_x86_regs
$clobber = "";
}
- foreach $reg (keys(%regs)) {
+ foreach my $reg (keys(%regs)) {
my $clobberprime = reg_name($clobber);
my $lastwordprime = reg_name($lastword);
my $val = $regs{$reg};
@@ -263,7 +265,7 @@ while (<FILE>) {
}
}
-close(FILE);
+close($file);
if ($counter == 0) {
print "No matching code found \n";
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
