Re: [PATCH] wrap long help lines, take two

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16.12.2009 05:56, Vadim Bendebury (вб) wrote:
> 2009/12/15 Michal Marek <mmarek@xxxxxxx>:
>> struct somename {
>>  struct gstr *gstr;
>>  int width;
>>  /* other bookkeeping stuff like last_line_length */
>> }
>>
>> Then expr_gstr_print would just initialize an instance of this structure
>> and pass it to expr_print as the callback argument.
> 
> I first thought about it, but decided against it, because the way it
> is now it is a much more contained change. Yes, recalculating string
> length every time is excessive, but in this particular case it is
> harmless.I am also worried of the string modified elsewhere bypassing
> the print helper function, which would take things out of sync and
> cause corrupted data.

expr_print() only sees a void pointer, so it can't modify any data
hidden behind it. But I don't care, do it as you like, just please move
the ncurses calls to menuconfig.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux