On Mon, Oct 12, 2009 at 4:41 PM, Michael Tokarev <mjt@xxxxxxxxxx> wrote: > Sam Ravnborg wrote: >> >> Hi Linus. >> >> A few kbuild related fixes. > > [] >> >> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users > > As has been discussed previously (and Sam has been CC'ed), the fix > is still incorrect. It replaces "echo -ne" with "/bin/echo -ne", > but neither of the two are guaranteed to support the necessary > arguments and necessary (hexadecimal) escape sequences. What should > be used here is printf(1). The trivial patch below (on top of these > kbuild changes) fixes this issue. > > Thanks. > > /mjt > > Signed-Off-By: Michael Tokarev <mjt@xxxxxxxxxx> > Sorry, I just saw this email. Hmm, printf(1) should be more portable than echo(1), I checked your patch, how about using 'printf "%b" ' instead? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
