On Tue, 2009-09-22 at 14:38 +0100, Alan Jenkins wrote: > + > +struct kernel_symbol > +{ > + unsigned long value; > + const char *name; > +}; One relevant checkpatch error above, ERROR: open brace '{' following struct go on the same line #71: FILE: include/linux/mod_export.h:13: +struct kernel_symbol +{ You have another similar one in patch 4 , ERROR: else should follow close brace '}' #99: FILE: kernel/module.c:221: + } + else if (cmp < 0) Could you correct those? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html