On Fri, Sep 18, 2009 at 09:49:53AM +0800, Am?rico Wang wrote: > On Thu, Sep 17, 2009 at 7:45 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Thursday 17 September 2009, Caveh Jalali wrote: > > > >> when the platform specific include directories were shuffled around > >> without updating the > >> top level Makefile. however, i think this FAIL is generic, and not > >> limited to powerpc. > >> here's a patch to the top level Makefile to teach it about the shuffled files: > >> > >> > >> --- /local/caveh/linux/linux-2.6.31/Makefile 2009-09-09 > >> 15:13:59.000000000 -0700 > >> +++ Makefile 2009-09-16 12:23:05.000000000 -0700 > >> @@ -958,9 +958,9 @@ ifneq ($(KBUILD_SRC),) > >> echo " in the '$(srctree)' directory.";\ > >> /bin/false; \ > >> fi; > >> - $(Q)if [ ! -d include2 ]; then \ > >> - mkdir -p include2; \ > >> - ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm; \ > >> + $(Q)if [ ! -d include2 ]; then \ > >> + mkdir -p include2; \ > >> + ln -fsn $(srctree)/arch/$(SRCARCH)/include/asm include2/asm; \ > >> fi > >> endif > > > > I think we should no longer have the include2 directory at all with new kernels. > > > > LINUXINCLUDE already contains the right path in theory: > > > > LINUXINCLUDE := -Iinclude \ > > $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \ > > -I$(srctree)/arch/$(hdr-arch)/include \ > > -include include/linux/autoconf.h > > Hmm, at least in mmotm, we still have include2... > > Maybe Sam is queueing the patches to remove include2? I have them queued - yes. But as they never hit -next they will wait another cycle. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
