On Thu, Jun 04, 2009 at 05:23:10PM +0800, Amerigo Wang wrote: > Sam Ravnborg wrote: > >On Thu, Jun 04, 2009 at 04:01:52AM -0400, Amerigo Wang wrote: > > > >>Remove a useless 'extern' in an exported header. > >>Fix a comment headers_check.pl. > >> > > > >These two patches has nothing in commom. > > > > They are both about kernel headers stuff. > > > > >>Signed-off-by: WANG Cong <amwang@xxxxxxxxxx> > >>Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > >> > >>------ > >>diff --git a/include/mtd/jffs2-user.h b/include/mtd/jffs2-user.h > >>index fa94b0e..10dc7ef 100644 > >>--- a/include/mtd/jffs2-user.h > >>+++ b/include/mtd/jffs2-user.h > >>@@ -18,7 +18,7 @@ > >> #undef je32_to_cpu > >> #undef jemode_to_cpu > >> > >>-extern int target_endian; > >>+int target_endian; > >> > > > >You now declare a global variable named target_endian each time you > >include this file - which is wrong. > > > Why? 'make headers_check' complains about it. Rightfully is does... But is think it is a prototype of a function. But think about it - it does not makes sense to have an extern declarationof a variable in an exported header. There is no way that userspace can access this variable from user-space and therefore the declaration of the variable needs to be moved to a kernel-only header file. So if you touch this I would ask you not to consider a single line in jffs-user.h - but rather take a critiacal look at the whole file and fix any issues there is. And then to send it to the mtd people (dwmw2). I did not look at the file but just looking at yout patch the "undef jemode_to_cpu" looks fishy in an exported header. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
