On Thu, 30 Apr 2009, Alan Jenkins wrote: > > + > > + if (/CONFIG_IKCONFIG/) { > > + if (/# CONFIG_IKCONFIG is not set/) { > > + # enable IKCONFIG at least as a module > > + print "CONFIG_IKCONFIG=m\n"; > > + # don't ask about PROC > > + print "# CONFIG_IKCONFIG is not set\n"; > > I assume the second one should be CONFIG_IKCONFIG_PROC :-). Ag! Thanks! > > > + } else { > > + print; > > + } > > + next; > > + } > > + > > + if (/^(CONFIG.*)=(m|y)/) { > > + if (defined($configs{$1})) { > > + $setconfigs{$1} = $2; > > + print; > > + } elsif ($2 eq "m") { > > + print "# $1 is not set\n"; > > } else { > > - print; > > + print; > > } > > > + } else { > > + print; > > + } > > > Maybe it would be cleaner make the two "if" blocks the same; i.e. do > this instead: Yeah, that does look cleaner. -- Steve > > + next; > + } > + > + print; > > > > } > > close(CIN); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html