Re: [PATCH] fix spurious initramfs rebuild

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 09, 2009 at 06:49:52PM +0100, Maxime Bizon wrote:
> 
> Hello,
> 
> 
> 
> When gen_initramfs_list is used to generate make dependencies, it
> includes symbolic links, for which make tracks the link target. Any
> change to that target will cause an initramfs rebuild, even if the
> symlink points to something outside of the initramfs directory.
> 
> If the target happens to be /tmp, the rebuild occurs for each kernel
> build, since gen_initramfs_list uses mktemp...
> 
> Proposed way to fix it is to omit symbolic links from generated
> dependencies, but this has a small drawback: changing perm/owner on a
> symlink will go unnoticed.
> 
> 
> Signed-off-by: Maxime Bizon <mbizon@xxxxxxxxxx>
> 
> --- linux-2.6.28.4/scripts/gen_initramfs_list.sh.old	2009-02-09 18:22:26.000000000 +0100
> +++ linux-2.6.28.4/scripts/gen_initramfs_list.sh	2009-02-09 18:21:54.000000000 +0100
> @@ -97,7 +97,7 @@
>  }
>  
>  list_parse() {
> -	echo "$1 \\"
> +	[ ! -L "$1" ] && echo "$1 \\" || :
>  }
>  
>  # for each file print a line in following format

Applied.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux