On Thu, Mar 12, 2009 at 4:31 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > On Thu, Mar 12, 2009 at 02:43:05PM +0100, Remis Lima Baima wrote: >> Generic headers allow ARCH maintainers to remove all dummy >> arch/ARCH/include/asm/XXX.h files or, depending on the architecture, >> include/asm-ARCH/XXX.h (e.g. arch/x86/include/asm/errno.h) that only >> include the _name equivalent_ include/asm-generic/XXX.h file >> (e.g. include/asm-generic/errno.h) with _no_ changes. It was called >> generic headers for short. Arnd Bergmann gave the original idea and >> asked me to implement it. > > Hi Remis. > > I recall having exchanged mails with Arnd about the topic before but > I have lost track of it. > > Why is it that we do not implment this using the following scheme: > > Create a new directory: > 1) include/generic/asm > 2) Add the directory to the searchpath _after_ all ARCH supplied search paths. > 3) Teach headers install about this new place > 4) Move all generic headers from asm-generic to this new home > and add a dummy "#include <generic/asm/foo.h>" in asm-generic > > Then we can delete all the one-liners in $ARCH/include/asm > which simply include the asm-generic version. > > Sam Actually this is a much better solution. I just tried it out for few files and it seems to work quite well. I will implement it and send the patch. But what do you think if, instead of creating the dummy "#include <generic/asm/foo.h>" in asm-generic, we create symlinks? I've heard about an "avoid-symlink policy" so it is more a sort of question than suggestion ;-) Remis -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
