* Frank Ch. Eigler <fche@xxxxxxxxxx> wrote: > Ingo Molnar <mingo@xxxxxxx> writes: > > > [...] > > there's i think the KVM usecase where markers are used > > essentially a printk()-alike flexible tracing facility. > > > > [...] > > ./vmx.c: KVMTRACE_3D(MSR_READ, vcpu, ecx, (u32)data, (u32)(data >> 32), > > ./vmx.c: KVMTRACE_3D(MSR_WRITE, vcpu, ecx, (u32)data, (u32)(data >> 32), > > ./vmx.c: KVMTRACE_0D(PEND_INTR, vcpu, handler); > > > > I think this could easily be converted to a wrapper around > > ftrace_printk() plus a "kvmtrace" ftrace plugin [...] > > It would be even easier converted to the markers API directly, > without the KVMTRACE* macro intermediary: > > before: > KVMTRACE_3D(MSR_READ, &svm->vcpu, ecx, (u32)data, > (u32)(data >> 32), handler); > after: > trace_mark(kvmtrace, "MSR_READ: %p, %08lx, %016Lx\n", > &svm->vcpu, ecx, data); > > All this already "just works". except that we are removing markers. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
