On 12/10/2008 01:41 PM, Sam Ravnborg wrote: > On Wed, Dec 10, 2008 at 01:10:13PM +0100, Jiri Slaby wrote: >> - export src and obj, so that we can check them in tags.sh >> - don't allow * expansion during sh function calls > > What benefit does this patch give us? > We do not use $obj neither $src in tags.sh. I'm confused... git kernel.org:/pub/scm/linux/kernel/git/sam/kbuild-next.git says: # Do not use full path is we do not use O=.. builds if [ ${src} == ${obj} ]; then tree= else tree=${srctree} fi in scripts/tags.sh. > Likewise we do not pass it non-expanded parameters. We do inside the script. Try to touch XYZ.S in your build tree, the tags.sh won't work then. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html