On Mon, Nov 24, 2008 at 10:31:08AM +0000, Ian Campbell wrote: > On Sun, 2008-11-23 at 00:16 +0100, Sam Ravnborg wrote: > > As no-one else wanted to do so - I now moved the tags support > > to a shell script of its own. > > The usage is the same: make {tags,TAGS,cscope} > > > > The ALLSOURCE_ARCHS suppport was lost in the transition - is it actually used by anyone? > > I'm the one who actually added it way back in > a0674e88d9c150e016a69e78e735f48772314c53 and to be honest I don't use it > anymore since I've changed jobs and only really do x86 now... > > I can't say if anyone else is using it though. > > > I have given the patch only some light testing. > > > > Could those of you that actually sues tags/cscope plese give it a try. > > I tested your second patch from the subsequent email and functionally it > seems fine, it currently includes include/asm-* for all architectures > but I suppose they will all go away shortly. > > The output was a bit odd though: > $ make cscope > /bin/sh /local/scratch/ianc/devel/linux-2.6.git/scripts/tags.sh cscope > GEN cscope.out (from 13251 files) > I guess I would have expected " GEN cscope.files" instead of the > first line or just " TAGS"? Thanks for testing Ian. I will fix up the invocation line to something like GEN {tags,TAGS,cscope} And then I will drop the extra output from the shell script in the cscope case. Is it OK that I add a: Tested-by: Ian Campbell <ijc@xxxxxxxxxxxxxx> to the patch? Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html