On Thu, Oct 30, 2008 at 02:31:50PM +0300, Alexey Dobriyan wrote: > On Thu, Oct 30, 2008 at 12:16:01PM +0100, Giacomo A. Catenazzi wrote: > > Adrian Bunk wrote: > >> On Wed, Oct 29, 2008 at 02:20:14PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > >>> From: Alexey Dobriyan <adobriyan@xxxxxxxxx> > >>> > >>> Add Kconfig token "module_name" to supply module's name. Example: > >>> > >>> config FOO > >>> tristate "foo" > >>> module_name foo > >>> ---help--- > >>> foo > >>> > >>> Print module's name as following on menuconfigs help screen (press 'h'): > >>> > >>> Module name: foo > >>> > >>> 8139too driver converted to show real-life example. > >>> > >>> P.S.: menuconfig only, no checking wrt modular/standalone code et al. > >>> ... > >> > >> We have 4 interfaces, and for not losing information all of them have > >> to support it. This is IMHO a blocker before you can change the 8139TOO option. > >>> --- a/drivers/net/Kconfig~kconfig-add-module_name-shortcut > >>> +++ a/drivers/net/Kconfig > >>> @@ -1549,14 +1549,12 @@ config 8139TOO > >>> depends on NET_PCI && PCI > >>> select CRC32 > >>> select MII > >>> + module_name 8139too > >>> ---help--- > >>> This is a driver for the Fast Ethernet PCI network cards based on > >>> the RTL 8129/8130/8139 chips. If you have one of those, say Y and > >>> read the Ethernet-HOWTO <http://www.tldp.org/docs.html#howto>. > >>> - To compile this driver as a module, choose M here: the module > >>> - will be called 8139too. This is recommended. > >>> - > >>> ... > >> > >> Are you planning any further usage of the module_name? > >> > >> Currently your patch seems to be in menuconfig equivalent to > >> > >> - To compile this driver as a module, choose M here: the module > >> - will be called 8139too. This is recommended. > >> + Module name: 8139too > >> > >> I don't have any strong opinion whether that's better or worse, but if > >> that's the only change we don't need a new kconfig syntax for it. > > Well, it can be extended into "goto Kconfig symbol which controls this module > [enter module name]". Or something else. >... Your patch lacks an addition to Documentation/kbuild/kconfig-language.txt describing the semantics. Can an option have two module_name entries if it results in two options being built? If yes, what is the syntax? Is it allowed to have several options listing the same module if each of them builds it? The semantics and syntax should be well-defined before we start converting one thousand kconfig options. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
