On Wed, Oct 29, 2008 at 07:51:13PM +0000, Ian Campbell wrote:
> On Wed, 2008-10-29 at 20:07 +0100, Sam Ravnborg wrote:
> > On Tue, Oct 28, 2008 at 01:36:25PM +0000, Ian Campbell wrote:
> > > Architectures which have moved their includes to arch/<ARCH>/include
> > > now list the headers twice in the source listing used by "make
> > > cscope" and friends, causing those tools to list symbols twice.
> > >
> > > Skipping these files in the ALLSOURCE_ARCHS pass rather than removing
> > > the ALLINCLUDE_ARCHS pass preserves the semantics of the later.
> > >
> > > Signed-off-by: Ian Campbell <ijc@xxxxxxxxxxxxxx>
> > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > > Cc: linux-kbuild@xxxxxxxxxxxxxxx
> > >
> > > diff -r a613b893f5b5 Makefile
> > > --- a/Makefile Mon Oct 27 10:29:49 2008 +0000
> > > +++ b/Makefile Tue Oct 28 13:33:04 2008 +0000
> > > @@ -1435,7 +1435,8 @@
> > > define find-sources
> > > ( for arch in $(ALLSOURCE_ARCHS) ; do \
> > > find $(__srctree)arch/$${arch} $(RCS_FIND_IGNORE) \
> > > - -name $1 -print; \
> > > + -wholename $(__srctree)arch/$${arch}/include/asm -type d -prune \
> > > + -o -name $1 -print; \
> > > done ; \
> > > find $(__srctree)security/selinux/include $(RCS_FIND_IGNORE) \
> > > -name $1 -print; \
> > >
> >
> > Hi Ian.
> >
> > I would much rather prefer to see a patch that
> > - support the platforms of arm and others
>
> How do you mean?
>
> $ ls arch/arm/include/
> asm/
>
> so it'll work as well for arm as it does for any other architecture.
fyi - I have applied your patch to kbuild-fixes.
I hope this stuff can be simplified one day.
I continue to see a steady stream of patches dealing with tags and cscope.
Maybe the right thing to do is to just move it all out in a shell
script so we do not clutter the makefile with all this.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
