On Sun, Jun 29, 2008 at 01:51:20PM +0200, Sam Ravnborg wrote: > Hi Roman. > > I was applying an old patch from you that introduces > conf_set_all_new_symbols(). > > But when I tested it I noticed that all symbols > of type "hex" were saved as decimal vlaues in .config. > > Sample (first line is with unmodifed kconfig): > > -CONFIG_RADIO_ZOLTRIX_PORT=0x20c > +CONFIG_RADIO_ZOLTRIX_PORT=20c > > I guess this has something to do with the way we > represent a hex value internally. But I have not yet > dived into it. > > Can you see where it goes wrong? This seems to be the right fix. Sam diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 0759761..6f39c80 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -510,7 +510,7 @@ int conf_write(const char *name) case S_HEX: str = sym_get_string_value(sym); if (str[0] != '0' || (str[1] != 'x' && str[1] != 'X')) { - fprintf(out, "CONFIG_%s=%s\n", sym->name, str); + fprintf(out, "CONFIG_%s=0x%s\n", sym->name, str); break; } case S_INT: -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html