On Thu, Jun 12, 2008 at 04:03:54PM +0200, roel kluin wrote: > 2008/6/12 Sam Ravnborg <sam@xxxxxxxxxxxx>: > > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > > index 508c589..b763aba 100644 > > --- a/scripts/mod/modpost.c > > +++ b/scripts/mod/modpost.c > > @@ -467,6 +467,26 @@ static void parse_elf_finish(struct elf_info *info) > > release_file(info->hdr, info->size); > > } > > > > +static int ignore_undef_symbol(struct elf_info *info, const char *symname) > > +{ > > + /* ignore __this_module, it will be resolved shortly */ > > + if (strcmp(symname, MODULE_SYMBOL_PREFIX "__this_module") == 0) > > + return 1; > > + /* ignore global offset table */ > > + if (strcmp(symname, "_GLOBAL_OFFSET_TABLE_") == 0) > > + return 1; > > + if (info->hdr->e_machine == EM_PPC) > > + /* Special register function linked on all modules during final link of .ko */ > > + if (strncmp(symname, "_restgpr_", sizeof("_restgpr_") - 1) == 0 || > > + strncmp(symname, "_savegpr_", sizeof("_savegpr_") - 1) == 0 || > > + strncmp(symname, "_rest32gpr_", sizeof("_rest32gpr_") - 1) == 0 || > > + strncmp(symname, "_save32gpr_", sizeof("_save32gpr_") - 1) == 0) { > > + return 1; > > + } > > Either the indentation is wrong, or you want to move the opening curly > bracket upwards. Deleted brackets - they are not needed. And updated kbuild-fixes.git Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html