On Sun, Jun 08, 2008 at 09:58:54PM +0100, David Woodhouse wrote: > It doesn't look like headers_check_all will work after your patches -- > but to be fair I don't think it worked _before_ them either. When you > run headers_install_all, there's no asm/ directory -- and thus the check > will fail for any headers in linux/ which try to include <asm/*.h>. > > Did this _ever_ work? It relied on what was installed in asm previously resulting in arbitary failures - which confused me a little. What I did in headers_check.pl was to introduce a second try. If we see a #include <asm/file.h> then we try both of: asm/file.h (first) asm-$arch/file.h (if the asm/file.h did not succeed) So with my version it actually works as expected and we hit a bug in cris. I've also implmented the feature that we stop on error so when cris has a bug we do not try the rest. It is both good and bad. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html