On Mon, May 19, 2008 at 08:42:45AM +0100, Jan Beulich wrote: > >>> Sam Ravnborg <sam@xxxxxxxxxxxx> 18.05.08 20:52 >>> > >> > >> I have several times been tempted to move it all to a shell script. > >> What has prevented me to do so has only been: > >> 1) that um has some subtle requirement and therefore redefine the > >> vmlinux link > >> 2) that last time I reworked this stuff Andrew could not boot one > >> of his systems and I never figured out why > >> 3) lack of time.. > >> > >> But if someone comes up with a patch that moves all this stuff out > >> of the top-level Makefile I am all open for it. > > > >I gave it a quick try. This is first try and comments are welcome. > >It does not address the um issue - but I think that is doable > >with an additional enviroment variable. > > > >The conditionals around KALLSYMS may be simplified - I just did > >not try to do so. > > What I fail to see is how the multi-stage (necessary even without > CONFIG_KALLSYMS_EXTRA_PASS) kallsyms linking is now happening. I will recheck my script tonight or tomorrow. But the principle is like this: -> Link vmlinux.o -> modpost vmlinux.o -> link vmlinux if not KALLSYMS -> link .tmp_vmlinux_kall if KALLSYMS -> link vmlinux with new kernel symbols if not KALLSYM_EXTRA_PASS -> link .tml_vmlinux_extra_pass if KALLSYM_EXTRA_PASS -> link vmlinux with new kernel symbols -> check that System.map are equal in the above two cases > > >What I like with the patch below is that it is 100 times more > >readable than the Makefile stuff. > > Fully agree, and hence I'd favor this for .27 over the simple version > handling fix (which I'd hope to see in .26, and maybe even .25.x). Does it fix anything or is it just a clean-up? I see it as a cleanup only and thus not -rc material. > >The drawback are that we either link or not - we cannot restart > >from the middle of the link. But that it not a real issue. > > > >This patch futhermore remove a debug target to assist in > >kallysms issues - I have not seen it used for a long time > >now. > > Is this what I referred to above? If so, I don't think these are just > debug targets... Nope - we can create maps of kernel symbols to assist when we have kernel symbols bugs (when EXTRA_PASS detect inconsistency). When I added this commit I told Keith Ownes that I planned to remove that again when we no longer saw KALLSYMS issues where we needed this to debug it. And I have not seen such reports for a long time now. > > >And I was also considering removing the extra kallsyms > >pass as I dunnot how usefull it is and for an allyesconfig > >build it take too much time. > > I'd vote for it, but would of course think that whoever introduced it > should voice his opinion. > > >This patch includes your version simplifactions too allthough > >that is not obvious. > > Thanks, Jan > I will post an updated patch later this week. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
