>PS. Mikael - should Jesper be mentioned in MAINTAINERS? Yes, that is a good idea. Down the road Jesper will take over maintainership I guess. -----Original Message----- From: Sam Ravnborg [mailto:sam@xxxxxxxxxxxx] Sent: Tuesday, January 01, 2008 11:20 AM To: WANG Cong Cc: Mikael Starvik; LKML; linux-kbuild@xxxxxxxxxxxxxxx; Andrew Morton; dev-etrax Subject: Re: [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles On Tue, Jan 01, 2008 at 03:29:22PM +0800, WANG Cong wrote: > > TOPDIR is obsolete, use objtree instead. > This patch removes TOPDIR from all Cris Makefiles. > > Cc: Mikael Starvik <starvik@xxxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> > > --- > > diff --git a/arch/cris/arch-v32/boot/compressed/Makefile b/arch/cris/arch-v32/boot/compressed/Makefile > index 9f77eda..8586922 100644 > --- a/arch/cris/arch-v32/boot/compressed/Makefile > +++ b/arch/cris/arch-v32/boot/compressed/Makefile > @@ -7,7 +7,7 @@ > target = $(target_compressed_dir) > src = $(src_compressed_dir) > > -CC = gcc-cris -mlinux -march=v32 -I $(TOPDIR)/include > +CC = gcc-cris -mlinux -march=v32 -I $(objtree)/include As in the mips case the right fix is to use: > +CC = gcc-cris -mlinux -march=v32 -Iinclude -Iinclude2 In this way we pick up the includes also in the O=.. case. PS. Mikael - should Jesper be mentioned in MAINTAINERS? Sam - To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html