On Tue, Jan 01, 2008 at 06:37:29PM +0100, Sam Ravnborg wrote: >On Tue, Jan 01, 2008 at 11:27:37AM -0600, Eric Sandeen wrote: >> WANG Cong wrote: >> > TOPDIR is obsolete, use objtree instead. >> > This patch removes TOPDIR from all fs/ Makefiles. >> >> > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile >> > index 49e3e7e..d1d3d49 100644 >> > --- a/fs/xfs/Makefile >> > +++ b/fs/xfs/Makefile >> > @@ -1 +1 @@ >> > -include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL) >> > +include $(objtree)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL) >> >> FWIW $(TOPDIR) is already banished from the latest xfs build code: >> >Good - I will ignore the xfs bits. Thanks. I will drop the xfs part. -------> Remove dead code in smbfs makefile. Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Tim Shimmin <xfs-masters@xxxxxxxxxxx> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> --- diff --git a/fs/smbfs/Makefile b/fs/smbfs/Makefile index 6673ee8..4faf8c4 100644 --- a/fs/smbfs/Makefile +++ b/fs/smbfs/Makefile @@ -16,23 +16,3 @@ EXTRA_CFLAGS += -DSMBFS_PARANOIA #EXTRA_CFLAGS += -DDEBUG_SMB_TIMESTAMP #EXTRA_CFLAGS += -Werror -# -# Maintainer rules -# - -# getopt.c not included. It is intentionally separate -SRC = proc.c dir.c cache.c sock.c inode.c file.c ioctl.c smbiod.c request.c \ - symlink.c - -proto: - -rm -f proto.h - @echo > proto2.h "/*" - @echo >> proto2.h " * Autogenerated with cproto on: " `date` - @echo >> proto2.h " */" - @echo >> proto2.h "" - @echo >> proto2.h "struct smb_request;" - @echo >> proto2.h "struct sock;" - @echo >> proto2.h "struct statfs;" - @echo >> proto2.h "" - cproto -E "gcc -E" -e -v -I $(TOPDIR)/include -DMAKING_PROTO -D__KERNEL__ $(SRC) >> proto2.h - mv proto2.h proto.h - To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
