On Mon, Nov 26, 2007 at 11:25:50AM -0800, Randy Dunlap wrote:
> Hi Sam,
>
> Have you had a chance to look at this kbuild issue?
>
>
> "make -B [all]" (after make *config) produces this (exits with error):
>
> linux-2.6.24-rc2-git5> make -B
> # Do not try to update included dependency files
> # Do not try to update included dependency files
> # Do not try to update included dependency files
> # Do not try to update included dependency files
> # Do not try to update included dependency files
> # Do not try to update included dependency files
> gcc -m elf_x86_64 /tester/linsrc/linux-2.6.24-rc2-git5/arch/x86/Makefile.o -o /tester/linsrc/linux-2.6.24-rc2-git5/arch/x86/Makefile
> gcc: /tester/linsrc/linux-2.6.24-rc2-git5/arch/x86/Makefile.o: No such file or directory
> gcc: no input files
> make: *** [/tester/linsrc/linux-2.6.24-rc2-git5/arch/x86/Makefile] Error 1
>
Took a look now.
Following patch fixes it. Problem is that I have not understood
fully WHY this patch fixes this issue.
The change to the top-level Makefile is cosmetic only, the real fix
is the change in arch/x86/Makefile
Anyone else that can sched some light on this?
I recall I put that rule in as a simple performance optimization.
Sam
diff --git a/Makefile b/Makefile
index b9934cf..333a734 100644
--- a/Makefile
+++ b/Makefile
@@ -1554,7 +1554,8 @@ targets := $(wildcard $(sort $(targets)))
cmd_files := $(wildcard .*.cmd $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd))
ifneq ($(cmd_files),)
- $(cmd_files): ; # Do not try to update included dependency files
+# Do not try to update included dependency files
+ $(cmd_files): ;
include $(cmd_files)
endif
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 7aa1dc6..86f583f 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -7,9 +7,6 @@ else
KBUILD_DEFCONFIG := $(ARCH)_defconfig
endif
-# No need to remake these files
-$(srctree)/arch/x86/Makefile%: ;
-
ifeq ($(CONFIG_X86_32),y)
UTS_MACHINE := i386
include $(srctree)/arch/x86/Makefile_32
-
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
