On Tue, 20 Nov 2007, Sam Ravnborg wrote:
> On Tue, Nov 20, 2007 at 06:14:22AM -0500, Robert P. J. Day wrote:
... snip ...
> > it may be that that's what you want, but it's certainly not obvious
> > from the comment above it. at the very least, that comment should be
> > tweaked, no?
> It is what we want - so yes the comment should be updated. And the
> comment for the flags function should explain why we do this - why
> this is needed to support separate output directory.
well, i'm going to leave that with you, but feel free to apply any of
the following while you're there:
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index b96ea8d..b6cef7d 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -72,7 +72,7 @@ TMPOUT := $(if $(KBUILD_EXTMOD),$(firstword $(KBUILD_EXTMOD))/)
# try-run
# Usage: option = $(call try-run, $(CC)...-o "$$TMP",option-ok,otherwise)
-# Exit code chooses option. "$$TMP" is can be used as temporary file and
+# Exit code chooses option. "$$TMP" can be used as temporary file and
# is automatically cleaned up.
try-run = $(shell set -e; \
TMP="$(TMPOUT).$$$$.tmp"; \
@@ -150,7 +150,7 @@ echo-cmd = $(if $($(quiet)cmd_$(1)),\
# printing commands
cmd = @$(echo-cmd) $(cmd_$(1))
-# Add $(obj)/ for paths that are not absolute
+# Add $(obj)/ prefix for paths that are not absolute
objectify = $(foreach o,$(1),$(if $(filter /%,$(o)),$(o),$(obj)/$(o)))
###
@@ -162,7 +162,7 @@ objectify = $(foreach o,$(1),$(if $(filter /%,$(o)),$(o),$(obj)/$(o)))
# See Documentation/kbuild/makefiles.txt for more info
ifneq ($(KBUILD_NOCMDDEP),1)
-# Check if both arguments has same arguments. Result is empty string if equal.
+# Check if argument lists are equivalent. Result is empty string if equal.
# User may override this check using make KBUILD_NOCMDDEP=1
arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \
$(filter-out $(cmd_$@), $(cmd_$(1))) )
@@ -174,7 +174,7 @@ endif
# in $(cmd_xxx) double $$ your perl vars
make-cmd = $(subst \#,\\\#,$(subst $$,$$$$,$(call escsq,$(cmd_$(1)))))
-# Find any prerequisites that is newer than target or that does not exist.
+# Find any prerequisites that are newer than target or that do not exist.
# PHONY targets skipped in both cases.
any-prereq = $(filter-out $(PHONY),$?) $(filter-out $(PHONY) $(wildcard $^),$^)
@@ -201,7 +201,7 @@ if_changed_rule = $(if $(strip $(any-prereq) $(arg-check) ), \
$(rule_$(1)))
###
-# why - tell why a a target got build
+# why - tell why a target got built
# enabled by make V=2
# Output (listed in the order they are checked):
# (1) - due to target is PHONY
@@ -210,12 +210,12 @@ if_changed_rule = $(if $(strip $(any-prereq) $(arg-check) ), \
# (4) - due to command line change
# (5) - due to missing .cmd file
# (6) - due to target not in $(targets)
-# (1) PHONY targets are always build
+# (1) PHONY targets are always built
# (2) No target, so we better build it
# (3) Prerequisite is newer than target
# (4) The command line stored in the file named dir/.target.cmd
# differed from actual command line. This happens when compiler
-# options changes
+# options change
# (5) No dir/.target.cmd file (used to store command line)
# (6) No dir/.target.cmd file and target not listed in $(targets)
# This is a good hint that there is a bug in the kbuild file
rday
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
