Hi Mimi, > Violation tests are dependent on searching the $LOG file, which may > itself result in a ToMToU violation. Preempt getting an additional > violation during the tests by forcing the $LOG ToMToU violation > earlier. > Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxxxxx> > --- > testcases/kernel/security/integrity/ima/tests/ima_violations.sh | 1 + > 1 file changed, 1 insertion(+) > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_violations.sh b/testcases/kernel/security/integrity/ima/tests/ima_violations.sh > index 37d8d473c..22863fb72 100755 > --- a/testcases/kernel/security/integrity/ima/tests/ima_violations.sh > +++ b/testcases/kernel/security/integrity/ima/tests/ima_violations.sh > @@ -30,6 +30,7 @@ setup() > if [ ! -e "$LOG" ]; then > tst_brk TCONF "log file not found, install auditd" > fi > + exec 3< $LOG || tst_brk TBROK "failed to read log file" > tst_res TINFO "using log $LOG" If you don't mind, I would reverse the order to get info about which log is used: tst_res TINFO "using log $LOG" exec 3< $LOG || tst_brk TBROK "failed to read log file" Or, if it's needed to for some reason to run it before (no idea why, but I might miss something), I would merge it as: exec 3< $LOG || tst_brk TBROK "failed to read $LOG" tst_res TINFO "using log $LOG" Reviewed-by: Petr Vorel <pvorel@xxxxxxx> Kind regards, Petr
