On Thu, Feb 13, 2025 at 11:56:25AM +0800, Qunqin Zhao wrote: > > 在 2025/2/13 上午5:28, Jarkko Sakkinen 写道: > > On Wed, Feb 12, 2025 at 11:31:13AM +0800, Qunqin Zhao wrote: > > > TPM2.0 is implemented in Loongson security engine. This is the driver > > TPM 2.0 or just TPM2 (either is fine with me). Quick reminder what > > Loongson security engine (I could not know that and it would be nice > > to have that in git log). > > Looks like just TPM2 is better. Either is fine :-) > > Some explanations about Loongson security engine will be added to git log. > > > > > > for it. > > > > > > Co-developed-by: Yinggang Gu <guyinggang@xxxxxxxxxxx> > > > Signed-off-by: Yinggang Gu <guyinggang@xxxxxxxxxxx> > > > Signed-off-by: Qunqin Zhao <zhaoqunqin@xxxxxxxxxxx> > > > --- > > > MAINTAINERS | 1 + > > > drivers/char/tpm/Kconfig | 9 ++++ > > > drivers/char/tpm/Makefile | 1 + > > > drivers/char/tpm/tpm_lsse.c | 104 ++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 115 insertions(+) > > > create mode 100644 drivers/char/tpm/tpm_lsse.c > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 6493d58436..6aad0f08ad 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -13484,6 +13484,7 @@ LOONGSON CRYPTO DRIVER > > > M: Qunqin Zhao <zhaoqunqin@xxxxxxxxxxxx> > > > L: linux-crypto@xxxxxxxxxxxxxxx > > > S: Maintained > > > +F: drivers/char/tpm/tpm_lsse.c > > > F: drivers/crypto/loongson/ > > > LOONGSON-2 APB DMA DRIVER > > Probably MAINTAINERS update should be a separate patch. > > Some MAINTAINERS updates are not separated form the driver patch. Like > the submit of "drivers/mfd/max7714*". > > So it seems whether the updates to MAINTAINERS are separated or not is OK. I'd prefer them separated from code changes. They are separate tasks per se. BR, Jarkko
