On Fri, Jan 17, 2025 at 04:47:05PM +0100, Mickaël Salaün wrote: > On Fri, Jan 17, 2025 at 03:42:22PM +0100, Günther Noack wrote: > > Do you want to add a comment next to these, to remind ourselves do undo this? > > You are surely not planning to support old versions of glibc indefinitely? > > I don't about glibc. Minimal versions for other tools are documented > here though: > https://docs.kernel.org/process/changes.html > > Nathan, Jon, any idea? I do not know if the idea of setting a minimum supported version of a libc has ever come up before (at least I am unaware of one). I suspect most people do a patch like this then move on because it is the maximally compatible option and these samples are not changing much, are they? This is the first build error I can recall seeing as a result of using an older glibc environment. If we would like to seriously consider setting a minimum supported version of glibc, it deserves a conversation with a wider audience since it could impact areas other than the samples, such as host tools (and IMHO, feels like a big hammer). Cheers, Nathan